-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #995: Publish symbols as .snupkg #1309
Conversation
This might cause a conflict with #1308 because of the addition of the PackageReadme element in the .csproj. Probably should merge that first so I can take the update in here. |
Codecov Report
@@ Coverage Diff @@
## develop #1309 +/- ##
========================================
Coverage 76.83% 76.83%
========================================
Files 188 188
Lines 5180 5180
Branches 1061 1061
========================================
Hits 3980 3980
Misses 702 702
Partials 498 498 Continue to review full report at Codecov.
|
OK, got that README thing merged in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; snupkg is generated by dotnet pack
.
Will we need to change anything about our release process in MyGet when we push to NuGet? Does MyGet know to carry the snupkg files along with it?
In MyGet, what you'll see is there are two download links - one for the package, one for the symbols. You'll also see the symbol server information right below the NuGet command line info, just above the release notes. When you go to push the package to NuGet, you need to make sure you check the "Include matching symbols packages" box. When it makes it over to NuGet, NuGet also has corresponding "download package/download symbols" links. We'll have to drop both into each release as artifacts instead of just the library package. |
Updates the build to produce a separate NuGet symbols package (.snupkg) so the .pdb is no longer embedded right in the main package. Reduces the size of the main package by over half (~2MB down to ~800KB).
I also organized the .csproj properties into logical sections because it was becoming quite the dumping ground. It was hard to see if things were already set or not.